[PATCH] D153107: [llvm-c] Add LLVMSetTailCallKind and LLVMGetTailCallKind
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 26 10:30:24 PDT 2023
aeubanks added a comment.
lgtm aside from some nits
can you add this to the release notes?
================
Comment at: llvm/include/llvm-c/Core.h:472
+/**
+ * Tail call kind for LLVMSetTailCallKind and LLVMGetTailCallKind.
+ *
----------------
can you add `@see CallInst::TailCallKind`?
================
Comment at: llvm/test/Bindings/llvm-c/echo.ll:106
+
+define i32 @musttailcall() {
+ %1 = musttail call i32 @call()
----------------
can you also add a `notail` test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153107/new/
https://reviews.llvm.org/D153107
More information about the llvm-commits
mailing list