[PATCH] D153335: [ELFAttributeParser] Skip unknown vendor subsections.

Mon Jun 26 10:09:12 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D153335#4448302 <https://reviews.llvm.org/D153335#4448302>, @simon_tatham wrote:

> In D153335#4446671 <https://reviews.llvm.org/D153335#4446671>, @MaskRay wrote:
>
>> Then just implement it as an extra file with `split-file` as well.
>
> I'm not sure about that. This particular test keeps its existing three sub-files in `lld/test/ELF/Inputs`. It would seem strange to use `split-file` for just this one extra one. Or do you mean you'd like me to reorganize the existing parts of the test while I'm here?

The new file can

The existing `llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t.o` can be changed to a part of `split-file`.
`Inputs/arm-vfp-arg-vfp-vendor.s` can be added as the second part.
The existing 3 `Inputs/arm-*` files are also used by `arm-tag-vfp-args-errs.s`. We don't need to convert them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153335/new/

https://reviews.llvm.org/D153335