[PATCH] D153730: [NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 09:48:34 PDT 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1a0d23efe157: [NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO (authored by wenlei).

Changed prior to commit:
  https://reviews.llvm.org/D153730?vs=534382&id=534619#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153730/new/

https://reviews.llvm.org/D153730

Files:
  llvm/test/tools/llvm-profgen/profile-density.test
  llvm/tools/llvm-profgen/ProfileGenerator.cpp


Index: llvm/tools/llvm-profgen/ProfileGenerator.cpp
===================================================================
--- llvm/tools/llvm-profgen/ProfileGenerator.cpp
+++ llvm/tools/llvm-profgen/ProfileGenerator.cpp
@@ -183,7 +183,7 @@
                             "set too low. Please check your command.\n";
   else if (Density < HotFunctionDensityThreshold)
     WithColor::warning()
-        << "AutoFDO is estimated to optimize better with "
+        << "Sample PGO is estimated to optimize better with "
         << format("%.1f", HotFunctionDensityThreshold / Density)
         << "x more samples. Please consider increasing sampling rate or "
            "profiling for longer duration to get more samples.\n";
Index: llvm/test/tools/llvm-profgen/profile-density.test
===================================================================
--- llvm/test/tools/llvm-profgen/profile-density.test
+++ llvm/test/tools/llvm-profgen/profile-density.test
@@ -4,7 +4,7 @@
 ; RUN: llvm-profgen --format=text --unsymbolized-profile=%S/Inputs/profile-density-cs.raw.prof --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t3 --show-density -hot-function-density-threshold=1 &> %t4
 ; RUN: FileCheck %s --input-file %t4 --check-prefix=CHECK-DENSITY-CS
 
-;CHECK-DENSITY: AutoFDO is estimated to optimize better with 3.1x more samples. Please consider increasing sampling rate or profiling for longer duration to get more samples.
+;CHECK-DENSITY: Sample PGO is estimated to optimize better with 3.1x more samples. Please consider increasing sampling rate or profiling for longer duration to get more samples.
 ;CHECK-DENSITY: Minimum profile density for hot functions with top 99.00% total samples: 3.2
 
 ;CHECK-DENSITY-CS: Minimum profile density for hot functions with top 99.00% total samples: 128.3


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153730.534619.patch
Type: text/x-patch
Size: 1800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230626/3727ca8f/attachment.bin>


More information about the llvm-commits mailing list