[PATCH] D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:991-992
 
-  // Function calls are not supported, so make sure we inline everything.
-  addPass(createAMDGPUAlwaysInlinePass());
-  addPass(createAlwaysInlinerLegacyPass());
+  if (!AMDGPUTargetMachine::EnableFunctionCalls ||
+      !AMDGPUTargetMachine::EnableLowerModuleLDS) {
+    // Function calls are not supported, so make sure we inline everything.
----------------
Currently the inliner gives a boost to the inline-threshold for functions that take alloca instructions as arguments (ArgAllocaCost in AMDGPUTargetTransformInfo.cpp).

Should that inline bonus be removed too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152414/new/

https://reviews.llvm.org/D152414