[PATCH] D153754: [AMDGPU] Introduce AMDGPU::SGPR_SPILL asm comment flag

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 05:09:46 PDT 2023


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:269
+  OS << "implicit-def: "
+     << printReg(RegNo, MF->getSubtarget().getRegisterInfo());
+
----------------
getSubtarget<GCNSubtarget>()?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.h:119
 
+  void emitImplicitDef(const MachineInstr *MI) const override;
+
----------------
I thought the mechanism for this was much more general but OK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153754/new/

https://reviews.llvm.org/D153754



More information about the llvm-commits mailing list