[PATCH] D153535: [AMDGPU][DAGISel] Be more flexible about what calls are allowed

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 04:32:13 PDT 2023


rovka added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/unsupported-calls.ll:65
 
-; GCN: :0:0: in function test_c_call_from_shader i32 (): unsupported calling convention for call from graphics shader of function defined_function
+; GCN-NOT: in function test_c_call_from_shader{{.*}}unsupported
 ; R600: in function test_c_call{{.*}}: unsupported call to function defined_function
----------------
arsenm wrote:
> Move these into your new test, they shouldn't be in the unsupported test anymore with not run lines
They're still unsupported on R600, so I think it's reasonable to leave them here. I can remove the NOT line, I guess it's not useful anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153535/new/

https://reviews.llvm.org/D153535



More information about the llvm-commits mailing list