[PATCH] D153749: [JITLink] Use SubtargetFeatures to store features in LinkGraph

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 02:58:42 PDT 2023


jobnoorman created this revision.
jobnoorman added a reviewer: lhames.
Herald added subscribers: asb, luke, pmatos, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, kbarton, hiraditya, nemanjai.
Herald added a project: All.
jobnoorman requested review of this revision.
Herald added subscribers: llvm-commits, wangpc.
Herald added a project: LLVM.

D149522 <https://reviews.llvm.org/D149522> introduced target features to LinkGraph. However, to avoid a
public dependency on MC, the features were stored in a std::vector
instead of using SubtargetFeatures directly.

Since SubtargetFeatures was moved from MC to TargetParser (D150549 <https://reviews.llvm.org/D150549>), we
can now use it directly to store the features. This patch implements
that and removes the (private) dependency on MC.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153749

Files:
  llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
  llvm/lib/ExecutionEngine/JITLink/CMakeLists.txt
  llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp
  llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.h
  llvm/lib/ExecutionEngine/JITLink/COFF_x86_64.cpp
  llvm/lib/ExecutionEngine/JITLink/ELFLinkGraphBuilder.h
  llvm/lib/ExecutionEngine/JITLink/ELF_aarch32.cpp
  llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp
  llvm/lib/ExecutionEngine/JITLink/ELF_i386.cpp
  llvm/lib/ExecutionEngine/JITLink/ELF_loongarch.cpp
  llvm/lib/ExecutionEngine/JITLink/ELF_ppc64.cpp
  llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp
  llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
  llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
  llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.h
  llvm/lib/ExecutionEngine/JITLink/MachO_arm64.cpp
  llvm/lib/ExecutionEngine/JITLink/MachO_x86_64.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153749.534478.patch
Type: text/x-patch
Size: 17750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230626/a61e99b9/attachment.bin>


More information about the llvm-commits mailing list