[PATCH] D153744: [LoopUnroll] adjust for new `convergent` semantics

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

In D153744#4448078 <https://reviews.llvm.org/D153744#4448078>, @JonChesterfield wrote:

> This looks quite high risk. How is it tested beyond this lit test, specifically with code that runs on the GPU? It's really easy to get broken transforms to pass a lit test where the checks were generated from the implementation.
>
> Also could you point reviewer's to the documentation on the heart intrinsic system and how it relates to the current modeling? I know there's a slide deque or two somewhere, hoping for something more formal.

Thanks for taking an interest, Jon. There's a reason why the intrinsics have the word "experimental" in their name. Risk is limited to any flow that actually decides to use them, and no one is being exhorted to actually run this stuff on their GPU at this point. As for documentation, there's definitely been a LOT more activity than just a "slide deck or two", both inside AMD as well as outside. Please do refer to the "stack" of reviews that this Phab review belongs to.

Also, there's this, for links to all historical stuff:
https://discourse.llvm.org/t/rfc-introduce-convergence-control-intrinsics/69613


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153744/new/

https://reviews.llvm.org/D153744