[PATCH] D153743: [RISCV] Use temporary stack in expanding SPLAT_VECTOR_SPLIT_I64_VL node
Yunze Zhu(Thead) via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 26 00:51:37 PDT 2023
Yunzezhu created this revision.
Yunzezhu added reviewers: craig.topper, asb.
Yunzezhu added a project: LLVM.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
Yunzezhu requested review of this revision.
Herald added subscribers: llvm-commits, wangpc, eopXD, MaskRay.
There is issue: https://github.com/llvm/llvm-project/issues/63515
This issue is because when expanding SPLAT_VECTOR_SPLIT_I64_VL node, only memoperand is used to create dependency. However in ScheduleDAGNodes, dependency is checked with chain only, and breaks order of store/load instructions.
I think in llvm.bitreverse.nxv2i64 intrinsic SPLAT_VECTOR_SPLIT_I64_VL nodes are parallel processed, so no chain should be add to these nodes.
Using temporary in expanding SPLAT_VECTOR_SPLIT_I64_VL node can keep vlse instruction get correct value no matter order of store instructions is changed.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D153743
Files:
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
llvm/test/CodeGen/RISCV/rvv/splat-vector-split-i64-vl-sdnode.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153743.534443.patch
Type: text/x-patch
Size: 4813 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230626/3f90af34/attachment-0001.bin>
More information about the llvm-commits
mailing list