[PATCH] D153219: [symbolizer] Exit early if input file is absent

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-json-code.test:7
-## Show how library errors are reported in the output.
-# RUN: llvm-symbolizer --output-style=JSON -e %p/no-file.exe 0 | \
-# RUN:   FileCheck %s -DMSG=%errc_ENOENT --check-prefix=NO-FILE --strict-whitespace --match-full-lines --implicit-check-not={{.}}
----------------
MaskRay wrote:
> jhenderson wrote:
> > This is possibly a case where we DO want the existing behaviour. The reasoning is that JSON output is intended to be 100% machine-readable.
> If we want to keep the test but make it more useful, we can specify two addresses on the command line and see how the error is presented. With the changes, the output is one JSON object with `Error`.
Both variants (old and new) are valid JSON files. When `llvm-symbolizer` processes address specified in command line, it also produces such JSON. I think this change in output could be considered as minor.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153219/new/

https://reviews.llvm.org/D153219