[PATCH] D153651: [gn] Add check-lsan target for Mac

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Cool!



================
Comment at: llvm/utils/gn/build/toolchain/target_flags.gni:57
+      "x86_64",
+    ]
+  }
----------------
iOS above also sets `target_ldflags`, don't we need that for mac? (If not, why not?)

Can we share code with the iOS path?


================
Comment at: llvm/utils/gn/secondary/BUILD.gn:28
+      "//compiler-rt/test/asan",
+      "//compiler-rt/test/lsan",
+    ]
----------------
You add this here in the `linux or win or amc` branch, but currently i'll only have an effect on mac due to supported_toolchains being non-empty only on mac, right? (i'm wondering if things will start failing on http://45.33.8.238/ once this goes in, but I think it should be fine?)


================
Comment at: llvm/utils/gn/secondary/compiler-rt/test/lsan/BUILD.gn:60
+    foreach(toolchain, supported_toolchains) {
+      _test_dir = rebase_path(
+              get_label_info(":lit_site_cfg($toolchain)", "target_gen_dir"),
----------------
i think we don't do the "leading subdir for local vars" think in llvm's gn files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153651/new/

https://reviews.llvm.org/D153651