[PATCH] D112696: CycleInfo: Introduce cycles as a generalization of loops

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.
Herald added a subscriber: StephenFan.
Herald added a project: All.


================
Comment at: llvm/docs/CycleTerminology.rst:35
+   said to be the *parent* of these cycles, and each of these cycles
+   is a *child* of C.
+
----------------
Hi @sameerds, I have a question about this: why does #5 talk about "a cycle C **with header H**" (which depends on a particular DFS), instead of "a cycle C with entries E" (which would not)? It seems like this would make the cycle nesting structure depend on the choice of DFS. Is that intentional? It is unavoidable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112696/new/

https://reviews.llvm.org/D112696