[PATCH] D152899: Introduce RThreadAccess pass

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 08:26:35 PDT 2023


yrouban added a comment.

In D152899#4444040 <https://reviews.llvm.org/D152899#4444040>, @arsenm wrote:

> Would this be better served with an intrinsic to read this register? Does the register need to be globally reserved or just within the local function?

Actually this new pass RThreadAccess generates reading the //rthread// register with //@llvm.read_register()//.
I believe that, the easiest rule would be to reserve the //rthread// register for all functions (in one module at least). This allow to not think if this register can be changed or not by other functions called.
So I'm thinking if it would be ok to set these options as module level metadata instead of cl::opt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152899/new/

https://reviews.llvm.org/D152899



More information about the llvm-commits mailing list