[PATCH] D153698: [InstCombine] canonicalize multi xor as cmp+select

[Allen zhong via Phabricator via llvm-commits]

Allen marked an inline comment as done.
Allen added a comment.

In D153698#4446371 <https://reviews.llvm.org/D153698#4446371>, @0xdc03 wrote:

> Have you verified that this fixes the original bug as well? I feel that should also be added as a test case.

The original bug need another patch, we should change the phi into select, so I'll add that later.



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4289
   transform(I->operands(), NewOps.begin(),
             [&](Value *V) { return V == Op ? RepOp : V; });
 
----------------
nikic wrote:
> This would be the place to recursively call simplifyWithOpReplaced().
Thanks, apply your comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153698/new/

https://reviews.llvm.org/D153698