[PATCH] D152399: [CodeGen] Fine tune MachineFunctionSplitPass (MFS) for FSAFDO.

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 24 12:23:43 PDT 2023


tschuett added a comment.

For optionals please do not use `.has_value()`.

  if (optional) {
  }
  
  if (optional.has_value() {
  }

Is identical. Please use `.has_value()`only in unit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152399/new/

https://reviews.llvm.org/D152399



More information about the llvm-commits mailing list