[PATCH] D153335: [ELFAttributeParser] Skip unknown vendor subsections.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Code looks good to me. For the test, GNU readelf gives a warning.

  % readelf -A avfpvendor.o
  Attribute Section: ShouldBeIgnored
  readelf: Error: Bad subsection length (4294967295 > 12)
  Unknown tag: 255
    Unknown attribute:
    0x00000000 ffffffff ffffff                     .......

Can we use `llvm-mc -filetype=obj` to construct the test? It will likely be more readable than the yaml file.

  .section .ARM.attributes,""
  ...    // directives with comments
  ...



================
Comment at: lld/test/ELF/Inputs/arm-vfp-arg-vfp-vendor.yaml:35
+      - Name:            .ARM.attributes
+...
----------------
`...` is optional and can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153335/new/

https://reviews.llvm.org/D153335