[PATCH] D153645: [PowerPC][TLS] Add additional TLS X-Form loads/store instructions

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 24 05:05:59 PDT 2023


amyk marked an inline comment as done.
amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:783-785
+      Opcode = (RegVT == MVT::i32) ? isSExt ? PPC::LHAXTLS_32 : PPC::LHZXTLS_32
+               : isSExt            ? PPC::LHAXTLS
+                                   : PPC::LHZXTLS;
----------------
lei wrote:
> I feel like this should be indented thus instead....
Discussed this and we agreed to check this to an `if/else` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153645/new/

https://reviews.llvm.org/D153645



More information about the llvm-commits mailing list