[llvm] a7fb865 - Revert "[llvm-profdata] Fix mixed-sign comparison warnings"

Douglas Yung via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 17:59:09 PDT 2023


Author: Douglas Yung
Date: 2023-06-23T17:57:37-07:00
New Revision: a7fb8659b2a418b0dafcb96337133e8b7fa1e03c

URL: https://github.com/llvm/llvm-project/commit/a7fb8659b2a418b0dafcb96337133e8b7fa1e03c
DIFF: https://github.com/llvm/llvm-project/commit/a7fb8659b2a418b0dafcb96337133e8b7fa1e03c.diff

LOG: Revert "[llvm-profdata] Fix mixed-sign comparison warnings"

This reverts commit a2e7f26160359ed3913badb5acdd05aa8c663b46.

The original patch (31af18b) will be reverted, so reverting this follow-up patch first.

Added: 
    

Modified: 
    llvm/unittests/tools/llvm-profdata/MD5CollisionTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/tools/llvm-profdata/MD5CollisionTest.cpp b/llvm/unittests/tools/llvm-profdata/MD5CollisionTest.cpp
index 4ae57cd711c17..d7fe15a33702f 100644
--- a/llvm/unittests/tools/llvm-profdata/MD5CollisionTest.cpp
+++ b/llvm/unittests/tools/llvm-profdata/MD5CollisionTest.cpp
@@ -114,7 +114,7 @@ TEST(MD5CollisionTest, TestCollision) {
   ASSERT_FALSE(Reader->read());
 
   std::vector<StringRef> &NameTable = *Reader->getNameTable();
-  ASSERT_EQ(NameTable.size(), 2U);
+  ASSERT_EQ(NameTable.size(), 2);
   StringRef S1 = NameTable[0];
   StringRef S2 = NameTable[1];
   ASSERT_NE(S1, S2);
@@ -131,7 +131,7 @@ TEST(MD5CollisionTest, TestCollision) {
   ExpectedFS.addBodySamples(9, 0, 0);
 
   SampleProfileMap &Profiles = Reader->getProfiles();
-  EXPECT_EQ(Profiles.size(), 1U);
+  EXPECT_EQ(Profiles.size(), 1);
   if (Profiles.size()) {
     auto &[Hash, FS] = *Profiles.begin();
     EXPECT_EQ(Hash, ExpectedHash);
@@ -141,7 +141,7 @@ TEST(MD5CollisionTest, TestCollision) {
   // Inserting S2 again should fail, returning the existing sample unchanged.
   auto [It1, Inserted1] = Profiles.try_emplace(S2, FunctionSamples());
   EXPECT_FALSE(Inserted1);
-  EXPECT_EQ(Profiles.size(), 1U);
+  EXPECT_EQ(Profiles.size(), 1);
   if (Profiles.size()) {
     auto &[Hash, FS] = *It1;
     EXPECT_EQ(Hash, ExpectedHash);
@@ -157,7 +157,7 @@ TEST(MD5CollisionTest, TestCollision) {
 
   auto [It2, Inserted2] = Profiles.try_emplace(S1, FS1);
   EXPECT_TRUE(Inserted2);
-  EXPECT_EQ(Profiles.size(), 1U);
+  EXPECT_EQ(Profiles.size(), 1);
   if (Profiles.size()) {
     auto &[Hash, FS] = *It2;
     EXPECT_EQ(Hash, ExpectedHash);


        


More information about the llvm-commits mailing list