[PATCH] D153486: [llvm-profdata] GUIDToFuncNameMap can be static

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

V1 of this patch reverts things back to before D65848 <https://reviews.llvm.org/D65848>, and D65848 <https://reviews.llvm.org/D65848> was added to fix corruption from race condition.

The current version of this patch is similar to V1 of D65848 <https://reviews.llvm.org/D65848>, but we removed TLS because of this comment on `LLVM_THREAD_LOCAL` in include/llvm/Support/Compiler.h:

  /// This is essentially an extremely restricted analog to C++11's thread_local
  /// support. It uses thread_local if available, falling back on gcc __thread
  /// if not. __thread doesn't support many of the C++11 thread_local's
  /// features. You should only use this for PODs that you can statically
  /// initialize to some constant value. In almost all circumstances this is most
  /// appropriate for use with a pointer, integer, or small aggregation of
  /// pointers and integers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153486/new/

https://reviews.llvm.org/D153486