[PATCH] D153588: [Pseudo Probe] Remove the assert of allowing only one call probe for a callsite.

Fri Jun 23 15:03:29 PDT 2023

hoy added a comment.

In D153588#4445416 <https://reviews.llvm.org/D153588#4445416>, @wenlei wrote:

>> Due to the the way .pseudo_probe section is decoded, probes of the same-named independent static functions are merged
>
> Is this because dwarf based name (the container for probes) doesn't have the concept of static function and all functions are keyed on names (TopLevelProbeFrameMap), so we can't differentiate static functions of the same name?

In this case the linkage names are also the same. Those functions are global ctors which bypass the unique linkage phase and end up same-named.

> I might misunderstand it initially, but this seems like a flaw we should try to fix? Two static functions can be completely different, and we need to have the capability to differentiate them..

User static functions has no such problem since they have unique linkage names for both elf and dwarf. It only happens to compiler-generated functions such as global ctors. Those functions are usually not hot functions. I'm not sure they are worth being fixed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153588/new/

https://reviews.llvm.org/D153588