[PATCH] D153655: [LTO][GlobalDCE] Use pass parameter instead of module flag for LTO phase

Fri Jun 23 14:37:10 PDT 2023

tejohnson added a comment.

In D153655#4445020 <https://reviews.llvm.org/D153655#4445020>, @aeubanks wrote:

> In D153655#4444985 <https://reviews.llvm.org/D153655#4444985>, @nikic wrote:
>
>> You need to also implement printing and parsing support for the new pass option.
>
> (https://reviews.llvm.org/D153437 as an example)

Ah missed that. Done.

I also updated new-pm-print-pipeline.ll to test the new parameter.

Expanded virtual-functions-visibility-post-lto.ll test to use globaldce with the new parameter in addition to testing by invoking the full regular LTO pass pipeline. I also expanded this to ensure the transformation doesn't occur if we don't specify the new parameter (or use a non-lto default pipeline).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153655/new/

https://reviews.llvm.org/D153655