[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 12:53:21 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/Transforms/EmbedBitcode/embed.ll:23
+; RUN: opt --mtriple x86_64-unknown-linux-gnu < %s -passes="embed-bitcode<thinlto;emit-summary>" -S \
+; RUN: | llc --mtriple x86_64-unknown-linux-gnu -filetype=obj \
+; RUN: | llvm-readobj - --sections --elf-output-style=JSON --pretty-print \
----------------
We normally indent  continuation lines with 2 spaces


================
Comment at: llvm/test/Transforms/EmbedBitcode/embed.ll:43
+; EXCLUDE-NEXT: },
+
----------------
delete trailing blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776



More information about the llvm-commits mailing list