[PATCH] D139816: [LTO] Don't generate invalid modules if "LTOPostLink" MD already exists

Fri Jun 23 10:56:57 PDT 2023

tejohnson added a comment.

In D139816#4443836 <https://reviews.llvm.org/D139816#4443836>, @Pierre-vh wrote:

> Removing new APIs, use existing ones
>
> I'm not sure about removing the flag yet, it's present in a lot of tests and the intention with this patch is to be almost a NFC and just fix a edge case compiler crash

All but 2 of the test uses are just incidental. Only 2 tests fail when this is removed - one is obsolete if the flag is removed (it was specifically just to test that the flag gets generated), and the other just needs to switch to using the LTO default pipeline. I have a small fix to GlobalDCEPass to get this passed down from the pass manager, I'll send it for review once I rerun all the tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139816/new/

https://reviews.llvm.org/D139816