[PATCH] D151908: [BOLT][DWARF] Output DWO files as they are being processed

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo marked 7 inline comments as done.
ayermolo added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:306
 getDWOName(llvm::DWARFUnit &CU,
-           std::unordered_map<std::string, uint32_t> *NameToIndexMap,
-           std::unordered_map<uint64_t, std::string> &DWOIdToName) {
+           std::unordered_map<std::string, uint32_t> *NameToIndexMap) {
   std::optional<uint64_t> DWOId = CU.getDWOId();
----------------
maksfb wrote:
> Do we ever invoke this function with a null `NameToIndexMap`?
Not anymore, it looks like.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1606
+  uint64_t DWOId = *CU.getDWOId();
+  MCSection *const StrOffsetSection = State.MCOFI->getDwarfStrOffDWOSection();
+  // Skipping CUs that we failed to load.
----------------
maksfb wrote:
> Do we need to assert that the section is non-null?
I guess in theory there might not be a str section somehow? Added just in case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151908/new/

https://reviews.llvm.org/D151908