[PATCH] D153645: [PowerPC][TLS] Add additional TLS X-Form loads/store instructions

Fri Jun 23 10:25:23 PDT 2023

lei accepted this revision as: lei.
lei added a comment.
This revision is now accepted and ready to land.

I don't know why adding new instructions would change where some older instructions are located in `P10InstrResources.td`, but since that is auto generated I will assume it is a separate issue that need to be looked into.
LGTM other then a nit.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:783-785
+      Opcode = (RegVT == MVT::i32) ? isSExt ? PPC::LHAXTLS_32 : PPC::LHZXTLS_32
+               : isSExt            ? PPC::LHAXTLS
+                                   : PPC::LHZXTLS;
----------------
I feel like this should be indented thus instead....

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153645/new/

https://reviews.llvm.org/D153645