[PATCH] D153262: Add named section flag "large" to objcopy

Fri Jun 23 09:32:25 PDT 2023

aeubanks added a comment.

In D153262#4444522 <https://reviews.llvm.org/D153262#4444522>, @tkoeppe wrote:

> In D153262#4444492 <https://reviews.llvm.org/D153262#4444492>, @aeubanks wrote:
>
>> yeah we should check if `Config.OutputArch` is `ELF::EM_X86_64`, in line with https://reviews.llvm.org/D148358
>
> And what do we do if the flag is requested but we're on the wrong architecture? A fatal error? That might be better than silently ignoring an nonsensical request.

yes and we should say that it's only supported on x86-64 in the error message

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153262/new/

https://reviews.llvm.org/D153262