[PATCH] D98426: [llvm-objcopy][Support] move writeToStream helper function to Support.

Haojian Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 08:42:46 PDT 2023


hokein added inline comments.
Herald added a project: All.


================
Comment at: llvm/lib/Support/raw_ostream.cpp:1003
+
+  unsigned Mode = sys::fs::all_read | sys::fs::all_write | sys::fs::all_exe;
+  Expected<sys::fs::TempFile> Temp =
----------------
is the all_exe mode intended here? (the clang-include-cleaner tool is using this API, I was debugging an issue where the file type of the modified file was changed executable).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98426/new/

https://reviews.llvm.org/D98426



More information about the llvm-commits mailing list