[PATCH] D153446: [CodeGen] Refactor ComplexDeinterleaving to run identification on Values instead of Instructions

Fri Jun 23 06:05:51 PDT 2023

NickGuy added inline comments.

================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:551
   unsigned Negs = 0;
   SmallVector<Instruction *> FNegs;
-  if (R0->getOpcode() == Instruction::FNeg ||
----------------
igor.kirillov wrote:
> igor.kirillov wrote:
> > It looks like `FNegs` is not used anywhere. Maybe I should delete it, or you had a plan for it?
> @NickGuy
The instructions within `FNegs` were initially stored within the the composite nodes, and were used to ensure that all the users were contained within the same graph. Now that the approach for that check has changed, I don't see a need for keeping `FNegs` around in its current state.
Feel free to remove it, we can always readd it if a need arises.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153446/new/

https://reviews.llvm.org/D153446