[llvm] fd33821 - [NFC] Remove leftover `inline` on some RuleMatcher functions

via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 02:40:30 PDT 2023


Author: pvanhout
Date: 2023-06-23T11:39:56+02:00
New Revision: fd338216508c6119aab83fd8bcb2e613c30ce190

URL: https://github.com/llvm/llvm-project/commit/fd338216508c6119aab83fd8bcb2e613c30ce190
DIFF: https://github.com/llvm/llvm-project/commit/fd338216508c6119aab83fd8bcb2e613c30ce190.diff

LOG: [NFC] Remove leftover `inline` on some RuleMatcher functions

Accidentally copy-pasted them into the .cpp while refactoring the file in D151432
Those functions are currently only used in the .cpp so it didn't cause an issue, but it causes an undefined reference if another file attempts to use them.

Added: 
    

Modified: 
    llvm/utils/TableGen/GlobalISelMatchTable.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/GlobalISelMatchTable.cpp b/llvm/utils/TableGen/GlobalISelMatchTable.cpp
index 50495beba0f72..a8516ddc3053f 100644
--- a/llvm/utils/TableGen/GlobalISelMatchTable.cpp
+++ b/llvm/utils/TableGen/GlobalISelMatchTable.cpp
@@ -792,7 +792,7 @@ void RuleMatcher::definePhysRegOperand(Record *Reg, OperandMatcher &OM) {
   }
 }
 
-inline InstructionMatcher &
+InstructionMatcher &
 RuleMatcher::getInstructionMatcher(StringRef SymbolicName) const {
   for (const auto &I : InsnVariableIDs)
     if (I.first->getSymbolicName() == SymbolicName)
@@ -801,8 +801,7 @@ RuleMatcher::getInstructionMatcher(StringRef SymbolicName) const {
       ("Failed to lookup instruction " + SymbolicName).str().c_str());
 }
 
-inline const OperandMatcher &
-RuleMatcher::getPhysRegOperandMatcher(Record *Reg) const {
+const OperandMatcher &RuleMatcher::getPhysRegOperandMatcher(Record *Reg) const {
   const auto &I = PhysRegOperands.find(Reg);
 
   if (I == PhysRegOperands.end()) {


        


More information about the llvm-commits mailing list