[PATCH] D153563: Use LVI to eliminate instructions during VP

[Nikita Popov via Phabricator via llvm-commits]

nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: StephenFan.

See https://llvm.org/docs/TestingGuide.html#precommit-workflow-for-tests and the following section for testing requirements.

TBH the entire patch makes very little sense to me.



================
Comment at: llvm/include/llvm/IR/ConstantRange.h:283
+  /// unsigned values in Other.
+  bool isUnsignedStrictlyHigherThan(const ConstantRange &Other) const;
+
----------------
I think you re-invented the `icmp()` method here. `CR1.icmp(ICmpInst::ICMP_UGT, CR2)` etc is how you're supposed to write these.


================
Comment at: llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:578
+    return true;
+  }
+  return false;
----------------
How does your code differ from the existing getPredicateAt() check above?

The tests you added already fold without your change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153563/new/

https://reviews.llvm.org/D153563