[PATCH] D153575: [TargetLowering] Better code generation for ISD::SADDSAT/SSUBSAT when operand sign is known

Fri Jun 23 00:55:00 PDT 2023

0xdc03 added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-saturating-arithmetic.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc -verify-machineinstrs  -mtriple=aarch64-linux-gnu -O3 -o - %s | FileCheck %s --check-prefixes=CHECK
+
----------------
nikic wrote:
> You can drop `-verify-machineinstrs`, `-O3` and `--check-prefixes=CHECK` here. `-verify-machineinstrs` is enabled under EXPENSIVE_CHECKS, and doesn't need to be added to most tests. `-O3` rarely differs from the default of `-O2` for llc. `--check-prefixes=CHECK` is already the default.
Done! Thanks for the information, I had just copied the RUN line from the adjacent test file: `aarch64-pmull2.ll`

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-saturating-arithmetic.ll:209
+declare i64 @llvm.smax(i64, i64)
+declare i64 @llvm.smin(i64, i64)
----------------
nikic wrote:
> Can you please commit the tests with baseline checks and then rebase the patch over that? See https://llvm.org/docs/TestingGuide.html#precommit-workflow-for-tests.
Done!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153575/new/

https://reviews.llvm.org/D153575