[PATCH] D153609: [llvm-objcopy] Add LoongArch support

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 00:44:46 PDT 2023


xen0n marked an inline comment as done.
xen0n added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:334
     {"elf32-sparcel", {ELF::EM_SPARC, false, true}},
     {"elf32-hexagon", {ELF::EM_HEXAGON, false, true}},
+    // LoongArch
----------------
jhenderson wrote:
> Whilst you're in the area, would you mind please adding the missing `// Hexagon` comment? It just helps readability of this table, and means Hexagon doesn't look like it's a variation on SPARC!
No problem; thanks for the suggestion! This is now added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153609/new/

https://reviews.llvm.org/D153609



More information about the llvm-commits mailing list