[PATCH] D153595: [llvm-addr2line] Exit early if the input file cannot be read
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 23 00:30:29 PDT 2023
jhenderson added a comment.
Looks good, but I'm wondering if it would be just better for @sepavloff to integrate this change into their original patch, as that patch has a fair amount of useful discussion on it.
Regardless, I'd like @sepavloff to sign off on this.
================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:482
+ // When an input file is specified, exit immediately if the file cannot be
+ // read. If getOrCreateModuleInfo suceeds, symbolizeInput will reuse the
+ // cached file handle.
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153595/new/
https://reviews.llvm.org/D153595
More information about the llvm-commits
mailing list