[PATCH] D153609: [llvm-objcopy] Add LoongArch support

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 00:02:25 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-objcopy/ObjcopyOptions.cpp:334
     {"elf32-sparcel", {ELF::EM_SPARC, false, true}},
     {"elf32-hexagon", {ELF::EM_HEXAGON, false, true}},
+    // LoongArch
----------------
Whilst you're in the area, would you mind please adding the missing `// Hexagon` comment? It just helps readability of this table, and means Hexagon doesn't look like it's a variation on SPARC!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153609/new/

https://reviews.llvm.org/D153609



More information about the llvm-commits mailing list