[PATCH] D153507: [SLP] Use vector types for cmp alt instructions costs

Thu Jun 22 23:22:53 PDT 2023

dmgreen added a comment.

> The test patch won't apply cleanly to top of trunk.

Yeah I have not committed the updated tests yet. It is common practice to split them out to show just the differences, and I tend to keep them locally until the patch gets further into a review in case they need more adjustment. I can commit them if it's useful, but you can grab the new file using the `View Options -> Show Raw File (Right)` button. Or do you mean the code in the SLPVectorizer? I think that sound apply to a recent checkout.

================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/extracts-from-scalarizable-vector.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
 ; RUN: opt -S -passes=slp-vectorizer -mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s

----------------
vporpo wrote:
> Perhaps set the -slp-threshold such that it gets vectorized?
The idea is that these shouldn't be vectorized. The degenerate case would get simplified by instsimplify to ret 0, so is not interesting. The with_inputs case doesn't gain anything from vectorization (the f128 fcmp's will just be scalarized, so the vectorized version has are twice as many fcmp, plus extra shuffles and the reduce).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153507/new/

https://reviews.llvm.org/D153507