[PATCH] D153503: [AMDGPU] Add opt-pipeline test for NewPM.

[Pravin Jagtap via Phabricator via llvm-commits]

pravinjagtap added a comment.

In D153503#4441472 <https://reviews.llvm.org/D153503#4441472>, @aeubanks wrote:

> do we really need to test every pass when it's almost identical to the existing tests? can we just test that the specific passes that AMDGPU adds are in the pipeline?

I think, then, we will not be able to capture changes required in pipeline when someone updates AMDGPU Pass which depends on non-target specific pass. For example, in D153349 <https://reviews.llvm.org/D153349>, the AMDGPUAtomicOptimizer uses dom-tree but updating the dom-tree in the pass and preserving the analysis did not ask for updating the any of the pipeline tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153503/new/

https://reviews.llvm.org/D153503