[PATCH] D147652: [symbolizer] Check existence of input file in GNU mode

Thu Jun 22 16:12:43 PDT 2023

MaskRay added a comment.

In D147652#4441851 <https://reviews.llvm.org/D147652#4441851>, @dblaikie wrote:

> In D147652#4439871 <https://reviews.llvm.org/D147652#4439871>, @MaskRay wrote:
>
>> There is a time-of-check-to-time-of-use issue that we can ignore (as we may wait on the addresses),
>
> I had the same concern there (& maybe @jhenderson did too) & claimed to be addressed/not a problem in https://reviews.llvm.org/D147652#4314914 but I didn't quite follow.
>
> What do you mean "as we may wait on the address" - like we could deal with this problem later? Any particular reason to do that, rather than avoiding introducing the time-of-check-to-time-of-use issue in the first place?

Apologies, my stamp was a bit hand-wavy. I saw your commend and investigated a bit more. I think D153595 <https://reviews.llvm.org/D153595> may be the direction?
I don't touch llvm-symbolizer as @sepavloff can do that in D153219 <https://reviews.llvm.org/D153219>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147652/new/

https://reviews.llvm.org/D147652