[PATCH] D144660: [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:740
 endif()
 
+if(COMPILER_RT_HAS_TRUNK_LLD AND LLVM_USE_LINKER STREQUAL "lld")
----------------
vitalybuka wrote:
> What is LLVM_ENABLE_LLD?
Looks like it's covered


================
Comment at: compiler-rt/test/hwasan/TestCases/sizes.cpp:22
 
+// REQUIRES: android
+
----------------
Please add comment like:
FIXME: Allocation sizes adjusted to trigger errors on Android. Support general Linux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144660/new/

https://reviews.llvm.org/D144660