[PATCH] D153511: [BasicAA] Don't short-circuit non-capturing arguments

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

makes sense to me



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:867-869
   // If the pointer is to a locally allocated object that does not escape,
   // then the call can not mod/ref the pointer unless the call takes the pointer
   // as an argument, and itself doesn't capture it.
----------------
can you update this comment with your explanation so it's clearer?


================
Comment at: llvm/test/Transforms/PhaseOrdering/dse-ephemeral-value-captures.ll:25
 
 ; FIXME: At the moment, the function is incorrectly simplified to unreachable.
 define i32 @test() {
----------------
remove FIXME


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153511/new/

https://reviews.llvm.org/D153511