[PATCH] D153574: [CostModel] Use operands argument in getInstructionCost in more places

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 15:00:49 PDT 2023


luke added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:1258
 
       if (Shuffle->changesLength()) {
         // Treat a 'subvector widening' as a free shuffle.
----------------
Note: the logic here still uses the instructions operands, and not the operands argument. But it still seems worthwhile using the argument where we can since the TTI hooks that are ultimately called are passed it. And presumably, that's what they use too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153574/new/

https://reviews.llvm.org/D153574



More information about the llvm-commits mailing list