[PATCH] D151906: [BOLT][DWARF] Fix new debug re-writer

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 14:39:23 PDT 2023


maksfb added inline comments.


================
Comment at: bolt/lib/Core/DIEBuilder.cpp:81-88
+    if (LocExpr.Form == dwarf::DW_FORM_exprloc)
+      Value =
+          DIEValue(dwarf::Attribute(LocExpr.Attr), dwarf::Form(LocExpr.Form),
+                   static_cast<DIELoc *>(AttrVal));
+    else
+      Value =
+          DIEValue(dwarf::Attribute(LocExpr.Attr), dwarf::Form(LocExpr.Form),
----------------
maksfb wrote:
> Use braces.
I take it back - you don't really have to here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151906/new/

https://reviews.llvm.org/D151906



More information about the llvm-commits mailing list