[PATCH] D130105: [NFC][AMDGPU] Refactor AMDGPUDisassembler

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

In D130105#3864667 <https://reviews.llvm.org/D130105#3864667>, @foad wrote:

> In D130105#3804814 <https://reviews.llvm.org/D130105#3804814>, @cmtice wrote:
>
>> [  6] ; RUN: %assemble -mcpu=gfx908 <1.s >1.o [FAIL]
>> %assemble -mcpu=gfx908 <1.s >1.o
>> bash: line 0: fg: no job control
>
> This seems pretty clear that lit has not applied the substitution for `%assemble` before passing the command line to the shell. But I don't know how that could have happened. @cmtice do you have a link to your actual build? Is there anything unusual about it?

I didn't make the connection that the lit substitutions would apply before bash sees the result, somehow. I am also curious why the substitution would not apply correctly,

In D130105#4441463 <https://reviews.llvm.org/D130105#4441463>, @arsenm wrote:

> Was this ever re-committed?

No, I never reproduced the issue and didn't have the time to keep chasing it down


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130105/new/

https://reviews.llvm.org/D130105