[PATCH] D153511: [BasicAA] Don't short-circuit non-capturing arguments

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D153511#4442041 <https://reviews.llvm.org/D153511#4442041>, @fhahn wrote:

> Hmm, I am a bit worried that fixing this here rather than marking them as capturing in the CaptureTracker leaves a potential door for mis-use of the general API. Perhaps it would be possible to just consider those calls as capturing, as in 
> D153577 <https://reviews.llvm.org/D153577>

Those calls aren't capturing the pointer though.

Do you mean you're worried about mis-use of the capture tracking API?

I think this makes sense, using capture tracking to infer mod/ref seems backwards. IIUC this analysis depends on `AAQI.CI->isNotCapturedBeforeOrAt()` agreeing with `Call->doesNotCapture()`, which seems brittle.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153511/new/

https://reviews.llvm.org/D153511