[PATCH] D151906: [BOLT][DWARF] Fix new debug re-writer

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/include/bolt/Core/DIEBuilder.h:1
+//===- bolt/Rewrite/DIEBuilder.h -----------------------------*- C++ -*-===//
+//
----------------
Update the path.


================
Comment at: bolt/include/bolt/Core/DIEBuilder.h:15
+
+#ifndef BOLT_REWRITE_DIE_BUILDER_H
+#define BOLT_REWRITE_DIE_BUILDER_H
----------------
Update the name of the macro too.


================
Comment at: bolt/include/bolt/Core/DIEBuilder.h:31
+#include <memory>
+#include <mutex>
+#include <optional>
----------------
Are you actually using mutexes?


================
Comment at: bolt/include/bolt/Core/DIEBuilder.h:122
+
+  /// Clone one attribute according the format. \return the size of this
+  /// attribute.
----------------



================
Comment at: bolt/lib/Core/DIEBuilder.cpp:1
-#include "bolt/Rewrite/DIEBuilder.h"
+#include "bolt/Core/DIEBuilder.h"
 #include "bolt/Core/BinaryContext.h"
----------------
This file needs a license header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151906/new/

https://reviews.llvm.org/D151906