[PATCH] D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 22 10:34:41 PDT 2023
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Seems plausible. Hopefully this won't get too in the way of new PM codegen support
================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:100
+ /// Callback function type for added extensions to a target.
+ using ExtensionFn = std::function<void(TargetPassConfig &)>;
+
----------------
Can this be function_ref?
================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:522
+ TargetPassConfig::ExtensionFn Fn)
+ :
+
----------------
drti wrote:
> ychen wrote:
> > format
> This was auto-formatted this way, either during arcanist processing or to satisfy some lint/format warnings. I'd be hesitant to change this, even though I agree it doesn't look "right".
Might as well try hitting this with clang-format again
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98591/new/
https://reviews.llvm.org/D98591
More information about the llvm-commits
mailing list