[PATCH] D141712: [GVN] Improve PRE on load instructions

Thu Jun 22 10:14:55 PDT 2023

DaniilSuchkov added a comment.

In D141712#4413696 <https://reviews.llvm.org/D141712#4413696>, @nikic wrote:

> @uabelho Thanks for the report, should be fixed by https://github.com/llvm/llvm-project/commit/282324aa4a6c29d5ce31c66f8def15d9bd8e84e4.
>
> (I did not add an additional test, because plenty of other tests already fail if we don't require `-debug` for this.)

Does it make sense to use `AssertingVH` instead of bare `Value*` in `GVNPass::ValueTable::valueNumbering` (and probably in some other places as well) to prevent such bugs?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141712/new/

https://reviews.llvm.org/D141712