[PATCH] D151396: [2/3][RISCV][POC] Model vxrm in LLVM intrinsics and machine instructions for RVV fixed-point instructions

Thu Jun 22 08:48:38 PDT 2023

craig.topper added a subscriber: zvookin.
craig.topper added a comment.

In D151396#4436311 <https://reviews.llvm.org/D151396#4436311>, @craig.topper wrote:

> In D151396#4436310 <https://reviews.llvm.org/D151396#4436310>, @dblaikie wrote:
>
>> FWIW, I/we (google) am seeing a failure internally on some Halide tests: `LLVM ERROR: Cannot select: intrinsic %llvm.riscv.vaadd` - I don't have a small repro to share, but might be worth reverting pre-emptively?
>
> I think this is because we changed the signature of the intrinsic, and Halide needs to be updated. Or we need to keep the old intrinsic names and their behavior for Halide. I think Halide ultimately does want the new behavior. Zalman had asked for it in the past.

@zvookin Are you still working on Halide?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151396/new/

https://reviews.llvm.org/D151396