[PATCH] D143645: [llvm] Fix MCSubtargetInfo::checkFeatures to handle unknown features correctly
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 22 07:53:29 PDT 2023
arsenm added a comment.
It seems like the only use of checkFeatures is for implementing hwmodes?
================
Comment at: llvm/unittests/CodeGen/TargetOptionsTest.cpp:71
+
+ ASSERT_NE(TM->getMCSubtargetInfo(), nullptr);
+
----------------
It's a gtest-ism that these should be swapped
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143645/new/
https://reviews.llvm.org/D143645
More information about the llvm-commits
mailing list