[PATCH] D153532: [X86] Remove unused TableGen classes and multiclasses.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 05:53:11 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSSE.td:5980
-/// SS41I_binop_rmi - SSE 4.1 binary operator with 8-bit immediate
-multiclass SS41I_binop_rmi<bits<8> opc, string OpcodeStr, SDNode OpNode,
-                           ValueType OpVT, RegisterClass RC, PatFrag memop_frag,
----------------
RKSimon wrote:
> I'd have expected BLENDPS et al to use this, but oddly they use the (almost identical) SS41I_blend_rmi 
Ah SS41I_blend_rmi handles commutation of the immediate - so we can't merge them back together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153532/new/

https://reviews.llvm.org/D153532



More information about the llvm-commits mailing list