[PATCH] D153503: [AMDGPU] Add opt-pipeline test for NewPM.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 03:24:07 PDT 2023


arsenm added a comment.

In D153503#4440143 <https://reviews.llvm.org/D153503#4440143>, @foad wrote:

> @aeubanks I think you previously suggested adding an AMDGPU RUN line to `llvm/test/Other/new-pm-defaults.ll` instead of doing this?

I'm somewhat against covering all targets in a single test like this. I think it just makes it more difficult to maintain. e.g. I hate touching tests like clang/test/Preprocessor/predefined-arch-macros.c, there's no real value shared by the common dummy code and now you have to sort out which run line failed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153503/new/

https://reviews.llvm.org/D153503



More information about the llvm-commits mailing list